Skip to content

Use valid names for R2 buckets #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

Use valid names for R2 buckets #657

merged 2 commits into from
May 9, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented May 9, 2025 •
edited
Loading

Wrangler will start enforcing valid bucket names even in dev, see cloudflare/workers-sdk#9165

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1ab2b55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vicb vicb requested review from conico974 and james-elicx May 9, 2025 08:27
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 9, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@657

commit: 1ab2b55

conico974
conico974 approved these changes May 9, 2025
View reviewed changes
Copy link
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little nit

@vicb
Copy link
Contributor Author

vicb commented May 9, 2025

Thanks for the reviews!

@vicb vicb merged commit 19155fe into main May 9, 2025
7 checks passed
@vicb vicb deleted the vicb/r2-bucket branch May 9, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@conico974 conico974 conico974 approved these changes

@james-elicx james-elicx james-elicx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicb @conico974 @james-elicx